Merged
Conversation
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 95234d4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 37 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Gustrb
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Contributor
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35733 +/- ##
========================================
Coverage 59.64% 59.64%
========================================
Files 2832 2832
Lines 68322 68322
Branches 15133 15133
========================================
Hits 40750 40750
Misses 24963 24963
Partials 2609 2609
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
aleksandernsilva
requested changes
Apr 8, 2025
Contributor
aleksandernsilva
left a comment
aleksandernsilva
left a comment
There was a problem hiding this comment.
Could you add a changeset for this change?
Co-authored-by: Aleksander Nicacio da Silva <aleksander.silva@rocket.chat>
aleksandernsilva
requested changes
Apr 8, 2025
Co-authored-by: Aleksander Nicacio da Silva <aleksander.silva@rocket.chat>
aleksandernsilva
approved these changes
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Added a translation key instead of just using correcting the typo.
Issue(s)
Steps to test or reproduce
Further comments
https://rocketchat.atlassian.net/browse/CONN-595